fix: replace the code sample related to the delete_documents method…
#868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with a correct one The code sample for the `delete_documents` method has been updated to use the `filter` argument correctly. The fix ensures that the code sample functions as expected. Fixes: meilisearch#867
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 721 721
=========================================
Hits 721 721 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Bors merge |
sanders41
added
the
skip-changelog
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #867
What does this PR do?
Updates the code sample to demonstrate the correct method call.
Replaces the dictionary usage with the direct usage of the filter argument.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!