Revert dictionary parameter back to optional #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52d352d. See: meilisearch#870 (comment)
sanders41
added
the
skip-changelog
Collaborator
|
@ellnix everything looks good here, it's just code-cov that is failing. I tried re-running and it failed again so I'll give it a bit and start it again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 748 748
=========================================
Hits 748 748
☔ View full report in Codecov by Sentry. |
sanders41
approved these changes
Oct 24, 2023
Collaborator
sanders41
left a comment
sanders41
left a comment
There was a problem hiding this comment.
Thanks for the update
Collaborator
|
bors merge |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 52d352d. See: #870 (comment)