Add utils.rb to meilisearch.gemspec #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bors bot
added a commit
that referenced
this pull request
Dec 7, 2021
270: Add Dir glob to prevent LoadError's again r=curquiza a=brunoocasali Related to #268 The issue was already fixed by #269 PR. But the idea of this PR is to prevent that kind of error from happening again in the future. Actually, I didn’t find a really good way to test this behavior in RSpec, if anyone has an idea, please ping me :) I've builded locally the gem and tested in irb, everything seems to be working fine: ```rb irb(main):001:0> require 'meilisearch' => true irb(main):002:0> MeiliSearch::VERSION => "0.17.2.beta" irb(main):003:0> new_client = MeiliSearch::Client.new('http://localhost:7700', 'masterKey') => #<MeiliSearch::Client:0x00007fa0f586b3c8 `@base_url="http://localhost:7700",` `@api_key="masterKey",` `@options={},` `@headers={"Content-Type"=>"application/json",` "X-Meili-API-Key"=>"masterKey"}, `@hea...` irb(main):004:0> new_client.indexes => [] irb(main):005:0> ``` Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268