Skip to content

Add a version to index-settings-macro crate #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

Add a version to index-settings-macro crate #404

merged 1 commit into from
Dec 14, 2022

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Dec 14, 2022

Fixes #403

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Dec 14, 2022
@bidoubiwa bidoubiwa requested a review from alallema December 14, 2022 11:13
alallema
alallema approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Dec 14, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build succeeded:

@bors bors bot merged commit d485ad2 into main Dec 14, 2022
@bors bors bot deleted the add_version_in_index_settings_macro branch December 14, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

publish latest release version to crates.io

3 participants

@bidoubiwa @alallema