Fix testing issue (see description for details)#3
Merged
melo merged 1 commit intomelo:masterfrom Oct 19, 2011
Merged
Conversation
Otherwise they're not considered "found in PATH", and the test fails.
melo
added a commit
that referenced
this pull request
Oct 19, 2011
Duh, what a stupid mistake... Thanks!
Owner
|
Relase 0.006 on the way to CPAN with your fixes. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you try and install Bash::Completion 0.005 (or any version other than 0.001, for that matter) on a fresh perl installation, it will fail. t/10-bash-completion.t fails because it expects the BashComplete plugin to be active, but bash-complete is not present in $PATH, so it isn't active. You can get around this by installing 0.001 first, but I've included a small patch to fix the test if you don't have Bash::Completion installed in your current perl installation yet.