Bump ex_m3u8 to v0.15.4. Properly handle absolute URIs for variant pl… #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aylists and segments. Fallback to MPEG-TS demuxer
FelonEkonom
reviewed
Oct 14, 2025
Comment on lines
+57
to
+68
| _other -> | ||
| Logger.warning(""" | ||
| Unsupported segment URI extension: #{segment_uri |> inspect()} | ||
| Falling back to recognizing segment as MPEG-TS container file. | ||
| You can force recognizing segment as CMAF container file | ||
| by providing `segment_format: :cmaf` to `ExHLS.Client/2`. | ||
| """) | ||
| end | ||
| end | ||
|
|
||
| def resolve_demuxing_engine_impl(_segment_uri, :ts), do: DemuxingEngine.MPEGTS | ||
| def resolve_demuxing_engine_impl(_segment_uri, :cmaf), do: DemuxingEngine.CMAF |
Member
There was a problem hiding this comment.
According to our discussion, let's use the value from the option only if segment doesn't have extension, instead of letting the option override segment extension containter
Member
There was a problem hiding this comment.
According to our discussion, we can move it to another PR 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aylists and segments. Fallback to MPEG-TS demuxer