Skip to content

Conversation

@noahp
Copy link
Collaborator

@noahp noahp commented Nov 21, 2025

Add esp32c6 board.

uart:~$ wifi connect -k 1 -s <ssid> -p <pw>
Connection requested
[00:00:20.404,000] <inf> net_dhcpv4: Received: 192.168.1.170
Connected
uart:~$ mflt post_chunks
[00:00:23.828,000] <inf> mflt: Posting Memfault Data
[00:00:23.829,000] <dbg> mflt: memfault_platform_log: Opening socket to chunks.memfault.com:443
[00:00:23.876,000] <dbg> mflt: memfault_platform_log: DNS lookup for chunks.memfault.com = 98.90.183.58
[00:00:24.303,000] <dbg> mflt: memfault_platform_log: Response Complete: Parse Status 0 HTTP Status 202!
[00:00:24.304,000] <dbg> mflt: memfault_platform_log: Body: Accepted
[00:00:24.309,000] <dbg> mflt: memfault_platform_log: No more data to send
[00:00:24.320,000] <inf> mflt: Data posted successfully, 62 bytes sent

Copilot AI review requested due to automatic review settings November 21, 2025 17:14
@noahp noahp requested a review from a team as a code owner November 21, 2025 17:14
Copilot finished reviewing on behalf of noahp November 21, 2025 17:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Memfault SDK from version 1.28.0 to 1.30.3 and Zephyr from 4.2.0 to 4.3.0, while adding support for the ESP32-C6 board. The main refactoring simplifies the device ID management by leveraging the SDK's built-in functionality instead of custom hwinfo-based implementation.

Key changes:

  • SDK versions updated to leverage built-in device info handling
  • Custom device ID retrieval code removed in favor of SDK-provided function
  • ESP32-C6 board support added with appropriate device tree configuration

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
west.yml Updates Zephyr to v4.3.0 and Memfault SDK to 1.30.3
src/main.c Removes custom device ID logic, uses SDK-provided function and CONFIG macros for device info
sample.yaml Adds esp32c6_devkitc board to platform allowlist
prj.conf Removes CONFIG_HWINFO as it's no longer needed
boards/esp32c6_devkitc_esp32c6_hpcore.overlay Adds device tree overlay for ESP32-C6 WiFi and temperature sensor support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


#include "app_version.h"
#include "memfault/components.h"
#include "memfault/ports/zephyr/core.h"
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header memfault/ports/zephyr/core.h is included but according to the comment on lines 14-15, the function memfault_zephyr_get_device_id() is not yet available in this header in the current SDK version. Since the Memfault SDK is being updated to 1.30.3, verify that this function is actually exported in that version's header. If not, the include may need to wait until a later SDK version, or the extern declaration is correct but the comment should clarify the current SDK version doesn't export it yet.

Copilot uses AI. Check for mistakes.
Add esp32c6 board.

```bash
uart:~$ wifi connect -k 1 -s <ssid> -p <pw>
Connection requested
[00:00:20.404,000] <inf> net_dhcpv4: Received: 192.168.1.170
Connected
uart:~$ mflt post_chunks
[00:00:23.828,000] <inf> mflt: Posting Memfault Data
[00:00:23.829,000] <dbg> mflt: memfault_platform_log: Opening socket to chunks.memfault.com:443
[00:00:23.876,000] <dbg> mflt: memfault_platform_log: DNS lookup for chunks.memfault.com = 98.90.183.58
[00:00:24.303,000] <dbg> mflt: memfault_platform_log: Response Complete: Parse Status 0 HTTP Status 202!
[00:00:24.304,000] <dbg> mflt: memfault_platform_log: Body: Accepted
[00:00:24.309,000] <dbg> mflt: memfault_platform_log: No more data to send
[00:00:24.320,000] <inf> mflt: Data posted successfully, 62 bytes sent
```
@noahp noahp force-pushed the noahp/update-memfault-and-zephyr branch from 8f72503 to ee92877 Compare November 21, 2025 23:01
@noahp noahp merged commit ed13d50 into main Nov 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants