refactor: use native uuid generator.#843
Closed
ghimirebibek wants to merge 4 commits intofirecrawl:mainfrom
Closed
refactor: use native uuid generator.#843ghimirebibek wants to merge 4 commits intofirecrawl:mainfrom
ghimirebibek wants to merge 4 commits intofirecrawl:mainfrom
Conversation
rafaelsideguide
requested changes
Oct 29, 2024
Collaborator
rafaelsideguide
left a comment
rafaelsideguide
left a comment
There was a problem hiding this comment.
Is it possible to remove the uuid module entirely?
Author
I've added a regex validation in place of uuid package's validate method. I've also removed uuid from the dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node comes with native version 4 uuid generator, so we do not need to import uuid package for it. I have not removed the uuid package because I saw it being use for validation too.