feat: added timeouts to requests to prevent blocking requests#890
Open
RRua wants to merge 1 commit intofirecrawl:mainfrom
Open
feat: added timeouts to requests to prevent blocking requests#890RRua wants to merge 1 commit intofirecrawl:mainfrom
RRua wants to merge 1 commit intofirecrawl:mainfrom
Conversation
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Add Optional Timeout Parameters to HTTP Requests
Summary
This pull request introduces optional
timeoutparameters to all functions in theFirecrawlAppclass that make HTTP requests. This enhancement improves the robustness and resilience of the application by ensuring that calls do not hang indefinitely, which helps prevent resource starvation and supports better error handling.Key Changes
Added
timeoutas an optional argument to the following functions:scrape_urlcrawl_urlasync_crawl_urlcheck_crawl_statusUpdated internal
_post_requestand_get_requestmethods to use thetimeoutvalue when provided.Default behavior remains unchanged if
timeoutis not specified, ensuring backward compatibility.Benefits