-
Notifications
You must be signed in to change notification settings - Fork 17
Feature/nanoflow #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nanoflow #13
Conversation
README.md
Outdated
| ## Features and limitations | ||
|
|
||
| * Adds timed behavior to your applications. | ||
| * Nanoflow support starts from Mendix 7.13.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run a Microflow or Nanoflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to mention version number as it will not be compatible < 7.13.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
| @@ -1,28 +1,32 @@ | |||
| # MicroflowTimer [](https://docs.mendix.com/community/app-store/app-store-content-support) | |||
| # ActionTimer [](https://docs.mendix.com/community/app-store/app-store-content-support) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space, not camel case "Action Timer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| <description>If true (and execute once is false), the microflow or nanoflow will be invoked the first time if the widget has loaded. If false, the microflow or nanoflow will be invoked the first time after interval has passed</description> | ||
| </property> | ||
| <property key="callEvent" type="enumeration" defaultValue="callMicroflow"> | ||
| <caption>Call event</caption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to Timer event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| nanoflow: null, | ||
| firstIntervalAttr: null, | ||
| intervalAttr: null, | ||
| timerStatusAttr: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post create add an error message when Timer event action does not have correct config (conditional required, microflow or nanoflow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used mendix default mx.ui.error("Error occured")
| } else if (this.callEvent === "callNanoflow" && this.nanoflow){ | ||
| this._executeNanoFlow() | ||
| } else { | ||
| mx.ui.error("No action specified for " + this.callEvent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To late, should be mentioned in postCreate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| _executeEvent: function() { | ||
| if(this.callEvent === "callMicroflow" && this.microflow) { | ||
| this._execMf() | ||
| } else if (this.callEvent === "callNanoflow" && this.nanoflow){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DANGER! never just test this.nanoflow this will always return true, as it is an object ALWAYS check this.nanoflow.nanoflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| } | ||
| }), | ||
| error: lang.hitch(this, function(error) { | ||
| mx.ui.error("An error ocurred while executing nanoflow" + error.message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also log this error to the logger.error so the error is shown in the console of the runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| mx.ui.error("An error ocurred while executing microflow" + error.message); | ||
| }) | ||
| }; | ||
| if (!mx.version || mx.version && parseInt(mx.version.split(".")[0]) < 7) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verison stuff, can be removed as this widget is no longer will run < 7.13.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/package.xml
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <package xmlns="http://www.mendix.com/package/1.0/"> | ||
| <clientModule name="MicroflowTimer" version="3.1.1" xmlns="http://www.mendix.com/clientModule/1.0/"> | ||
| <clientModule name="ActionTimer" version="3.2.0" xmlns="http://www.mendix.com/clientModule/1.0/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be major update, as this version will only run on mx 7.13 and up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to 4.0.0
58569d3 to
6fe961f
Compare
6fe961f to
60d1562
Compare
Add Nanoflow support