Skip to content

[WC-3079] Prevent Gallery from breaking in iframes #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

[WC-3079] Prevent Gallery from breaking in iframes #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/dropdown-sort-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed an issue with Gallery widget causing errors when Mendix app is being used in an iframe.

## [1.2.2] - 2025-03-31

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/dropdown-sort-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@mendix/dropdown-sort-web",
"widgetName": "DropdownSort",
"version": "3.3.0",
"version": "3.3.1",
"description": "Adds sorting functionality to Gallery widget.",
"copyright": "© Mendix Technology BV 2025. All rights reserved.",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/dropdown-sort-web/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="DropdownSort" version="3.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="DropdownSort" version="3.3.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="DropdownSort.xml" />
</widgetFiles>
Expand Down
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/gallery-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed an issue with Gallery widget causing errors when Mendix app is being used in an iframe.

## [3.4.0] - 2025-09-12

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/gallery-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@mendix/gallery-web",
"widgetName": "Gallery",
"version": "3.4.0",
"version": "3.4.1",
"description": "A flexible gallery widget that renders columns, rows and layouts.",
"copyright": "© Mendix Technology BV 2025. All rights reserved.",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/gallery-web/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Gallery" version="3.4.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Gallery" version="3.4.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="Gallery.xml" />
</widgetFiles>
Expand Down
5 changes: 4 additions & 1 deletion packages/shared/widget-plugin-sorting/src/react/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ export interface SortAPI {

const SORT_PATH = "com.mendix.widgets.web.sortable.sortContext";

// this is a magical way to check if we are running in design preview
const isDesignPreview = window.navigator.appVersion?.startsWith("Mendix Modeler");

export function getGlobalSortContext(): Context<SortAPI | null> {
const scope = window.top === window ? window : window.top;
const scope = isDesignPreview ? window.top : window;
return ((scope as any)[SORT_PATH] ??= createContext<SortAPI | null>(null));
}

Expand Down
Loading