[WC-3096] Gallery: fix divider gap spacing #1901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordan-st
force-pushed
the
fix/wc-3096_gallery-divider
branch
4 times, most recently
from
17cb7e9 to
104f9a4
Compare
gjulivan
reviewed
Sep 24, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery-design-properties.scss
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Sep 24, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery-design-properties.scss
Outdated
Show resolved
Hide resolved
yordan-st
force-pushed
the
fix/wc-3096_gallery-divider
branch
from
a43a010 to
7fc92ed
Compare
gjulivan
reviewed
Sep 26, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery-design-properties.scss
Outdated
Show resolved
Hide resolved
yordan-st
force-pushed
the
fix/wc-3096_gallery-divider
branch
2 times, most recently
from
b0303e8 to
67fe004
Compare
samuelreichert
previously approved these changes
Oct 7, 2025
yordan-st
force-pushed
the
fix/wc-3096_gallery-divider
branch
from
67fe004 to
e913dcd
Compare
samuelreichert
previously approved these changes
Oct 8, 2025
leonardomendix
previously approved these changes
Oct 15, 2025
yordan-st
dismissed stale reviews from leonardomendix and samuelreichert
via
d06772d
yordan-st
force-pushed
the
fix/wc-3096_gallery-divider
branch
from
e913dcd to
d06772d
Compare
gjulivan
approved these changes
Oct 17, 2025
leonardomendix
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Fixed an issue where setting the gallery gap to 0 would cause an offset, which made the bottom border of items to dissapear.
What should be covered while testing?
Set the gap to 0 and check if gallery items are spaced evenly and all border are visible