[WC-1716] Issue dg inf loop #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
changed the title
iobuhov
force-pushed
the
issue-dg-inf-loop
branch
from
b906e06 to
c3a7a29
Compare
iobuhov
changed the title
rahmanunver
previously approved these changes
Apr 19, 2023
packages/pluggableWidgets/datagrid-text-filter-web/src/features/filter-state.ts
Show resolved
Hide resolved
leonardomendix
previously approved these changes
May 1, 2023
added 18 commits
May 1, 2023 13:47
leonardomendix
previously approved these changes
May 1, 2023
samuelreichert
previously approved these changes
May 1, 2023
packages/pluggableWidgets/datagrid-text-filter-web/src/DatagridTextFilter.tsx
Outdated
Show resolved
Hide resolved
iobuhov
dismissed stale reviews from samuelreichert and leonardomendix
via
32dd867
leonardomendix
approved these changes
May 1, 2023
samuelreichert
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to change)
Description
This PR change how filters react on changes to the defaultValue attribute. Now we use value from this attribute only as initial value and any subsequent change is ignored.
What should be covered while testing?
Filter widgets - rendering and behavior.
You need a datagrid wrapped with dataview, which is used for storing and managing default values for the filters.
Current behavior:
changing filter value or showing/hiding filter through column selector cause multiple rerenders, poor performance and rendering erros in filter widgets.
Expected:
Changing filter value or hiding/showing filter should not cause any observable flickering or performance drops.