Added support for "array of objects" query parameter type. #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TKIPisalegacycipher
requested changes
Apr 21, 2025
Collaborator
TKIPisalegacycipher
left a comment
TKIPisalegacycipher
left a comment
There was a problem hiding this comment.
Thank you for this. Requesting a few changes so to improve code maintainability.
|
|
||
|
|
||
| def encode_params(_, data): | ||
| """Encode parameters in a piece of data. |
Collaborator
There was a problem hiding this comment.
I'd like to request more documentation here explaining why we're doing this. You can keep it high-level, but it should make sense to both folks familiar with the requests library, and also to folks who are not Python experts.
You might could reference issues in the GitHub tracker as well.
Added documentation for the new encode_params function
Added documentation for the new encode_params function
Added documentation for the new encode_params function
TKIPisalegacycipher
approved these changes
Apr 21, 2025
* Docstring updates * Added missing return statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for "array of objects" query parameter type.