Skip to content

Fix N+1 query in workflow visualization controller #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 22, 2025
Merged

Fix N+1 query in workflow visualization controller #10

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
221118f
Initial plan
Copilot Nov 22, 2025
d9f02d4
Fix N+1 query issue by using hash lookup for target steps
Copilot Nov 22, 2025
9a6795e
Add nil check for target_step to handle edge cases
Copilot Nov 22, 2025
7d1cbad
Merge branch 'main' into copilot/sub-pr-9
merefield Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/controllers/discourse_workflow/workflow_visualisation_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ def network
# Links: from each step via its options
links = []

# Build a hash of step_id => step to avoid N+1 queries
steps_by_id = steps.index_by(&:id)

steps.each do |step|
step.workflow_step_options.each do |option|
target_step = steps_by_id[option.target_step_id]
Expand Down