Skip to content

Fix N+1 query in workflow visualization controller #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2025
Merged

Fix N+1 query in workflow visualization controller #11

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfcbfcf
Initial plan
Copilot Nov 22, 2025
9861169
Fix N+1 query issue by using category lookup hash
Copilot Nov 22, 2025
729cb39
Add nil checks for category lookups
Copilot Nov 22, 2025
41948b1
Filter nil category_ids before database query
Copilot Nov 22, 2025
c97c1fd
Merge branch 'main' into copilot/sub-pr-9-again
merefield Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/controllers/discourse_workflow/workflow_visualisation_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,10 @@ def network
# Preload steps + options (and their workflow_option) to avoid extra queries when iterating
steps = workflow.workflow_steps.order(:position).includes(workflow_step_options: :workflow_option)

# Build a hash of category_id => category to avoid N+1 queries
category_ids = steps.filter_map(&:category_id).uniq
# Build category lookup hash to avoid N+1 queries
category_ids = steps.map(&:category_id).compact.uniq
categories_by_id = Category.where(id: category_ids).index_by(&:id)

# Build a hash of step_id => step for quick lookups in links
steps_by_id = steps.index_by(&:id)

# Lanes: unique categories in order of step position
lanes = steps.map do |step|
category = categories_by_id[step.category_id]
Expand Down