Retry request option added #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatejHamala
approved these changes
Mar 23, 2021
Collaborator
MatejHamala
left a comment
MatejHamala
left a comment
There was a problem hiding this comment.
📚 👍 Jsou tam dvě blbosti, který reálně nehrajou roli ale principiálně by je šlo udělat lépe. 🙂
mergadoapiclient/client.py
Outdated
| grant_type=None, storage_class=config.TOKEN_STORAGE_CLASS, | ||
| token_uri=config.TOKEN_URI, api_uri=config.MERGADO_API_URI): | ||
| token_uri=config.TOKEN_URI, api_uri=config.MERGADO_API_URI, | ||
| retry_status_list=[500, 502, 503, 504], tries=3): |
Collaborator
There was a problem hiding this comment.
V defaultních argumentech (a v podstatě všech pouze read-only proměnných) je vždy lepší používat immutable typy. Tzn mít místo seznamu retry_status_list=[500, 502, 503, 504] použít n-tici retry_status_list=(500, 502, 503, 504). 🙂
Imutable typy jsou v podstatě konstanty a tudíž si je python může při kompilaci natvrdo přeložit do bytekódu, místo toho aby vytvářel muttable objekty na haldě (s kterýma jsou všechny operace náročnější).
mergadoapiclient/client.py
Outdated
|
|
||
| def retry_request(make_request, retry_status_list, tries): | ||
| for i in range(tries): | ||
| wait = 2 ** i |
Collaborator
There was a problem hiding this comment.
tohle by šlo hodit až za ten if - většinou to totiž vůbec nebude potřeba počítat. 🙂
alby-m
force-pushed
the
requests_retry_session
branch
from
816ac33 to
dba48c0
Compare
-bump version to 0.1.5
alby-m
force-pushed
the
requests_retry_session
branch
from
dba48c0 to
bd024d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: MichalJanik/mergado#7962
Includes:
-added option for requests retrying when specified status codes are obtained from response
-status codes to trigger retry set defaultly to 500,502,503 and 504 (can be changed by spcecifying retry_status_list arg of codes when initializing client)
-number of tries defaultly set to 3 (can be changed by spcecifying tries arg when initializing client)