DateTime Conversion to ISO 8601 Compliant Format

[travis-hervey-pi]

In the various places where DateTime is being converted to ISO 8601 formats, the format string is wrong and results in an API error when trying to filter by the times.

Example:

merge-csharp-client/src/Merge.Client/Hris/Employees/EmployeesClient.cs

Line 94 in c03fb33

_query["modified_after"] = request.ModifiedAfter.Value.ToString("o0");

The above line produces "oO" as the time.

Proposed Solution:

The format string should be "0" which produces the ISO 8601 compliant time format.

_query["modified_after"] = request.ModifiedAfter.Value.ToString("o");

This looks like it needs to be applied to all the Client objects where filtering by a DateTime is possible.

[dsinghvi]

@travis-hervey-pi -- we are currently working on a fix for this. ccing @dcb6 to follow up here when a new SDK version is released.

[stellis]

@dsinghvi @dcb6 This is an enormous bug with what looks like a 2-min fix, but it's been open for four months. It makes this package look essentially unmaintained and doesn't inspire confidence in using it in production.

[dsinghvi]

@stellis @travis-hervey-pi this has been resolved on the latest version of the SDK and the fix has been live for 2 months (link:

merge-csharp-client/src/Merge.Client/Hris/Employees/EmployeesClient.cs

Lines 38 to 41 in a35417c

	if (request.CreatedAfter != null)
	{
	_query["created_after"] = request.CreatedAfter.Value.ToString(Constants.DateTimeFormat);
	}

)

Apologies for not commenting here sooner and if you have anymore issues, please let us know!