linting rules

[446564]

Should we decide on some formatting rules for linters?

I have format on save which I can of course disable but was wondering if we wanted to settle on some rules for formatting.

[446564]

for now I have just turn off formatting to avoid rewriting the whole file when I change one line.

[Hakira-Shymuy]

i second this

actually im part of a big community in portugal, and we are looking to adopt a network and protocol for our safe transmissions and emergency support, im talking probably around 500 people on active use and close to 3k as curious users, and it did catch our attention that meshcore did solve some stuff that meshtastic did not

at the same time we are reluctant due to the fact that the repository is a bit greeny
Would be nice to see the repo under one organization rather than a user, and some contribution guidelines, CI/CD i see that you guys are using for release versions, git convetional commits (https://www.conventionalcommits.org/en/v1.0.0/)

definitely would create more trust

Cheers

[Hakira-Shymuy]

clang-tidy and cppcheck might worth to take a look at

[446564]

looks like we have a .clang-format now, closing

[446564]

I think we should evaluate the currently included clang format configuration.

It seems to indent with spaces instead of tabs and breaks structures in a way that seems odd or at least not in line with the current codebase. As it stands if you save an existing file using this configuration a whole lot of formatting changes.

After that the entire project should be linted and formatted at once so we aren't changing entire files when making small changes.

[Hakira-Shymuy]

I think we should evaluate the currently included clang format configuration.

It seems to indent with spaces instead of tabs and breaks structures in a way that seems odd or at least not in line with the current codebase. As it stands if you save an existing file using this configuration a whole lot of formatting changes.

After that the entire project should be linted and formatted at once so we aren't changing entire files when making small changes.

The issue with the formatter Rules is that

UseTab: Never

So it will use spaces for the indentation
either use

UseTab: ForIndentation
or
UseTab: Always

in line 83

[446564]

The issue with the formatter Rules is that

UseTab: Never

So it will use spaces for the indentation either use

UseTab: ForIndentation or UseTab: Always

in line 83

Thank you, that fixes one issue 😎

[liamcottle]

Closing for now. Doesn't look like a big issue right now. Some users probably submit code from other editors and even GitHub UI which wouldn't adhere to style guidelines anyway. Just make sure your own IDE isn't making unnecessary changes when you do a commit.

[446564]

So then it's not fixed.

The codebase has linting rules committed that do not align with the current formatting and conventions in various files.

The file needs to be updated, removed or the whole project linted with it and enforced on commits.