Skip to content

companion: suspend radio when hibernating #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

companion: suspend radio when hibernating #1138

wants to merge 1 commit into from
+12 −0

Conversation

@yarda
Copy link

@yarda yarda commented Nov 22, 2025

This should significantly reduce power consumption in the hibernation.

Also explicitly shutdown peripherals (GPS, LED) on Heltec T114.

Fixes: #1014

@yarda
Copy link
Author

yarda commented Nov 22, 2025 •
edited
Loading

I am now testing it on Heltec T114 if it really saves power.

@yarda
companion: suspend radio when hibernating
dbd2e4c 
This should significantly reduce power consumption in the hibernation.

Implemented only for the SX126X radios, for others it's NOOP.

Also explicitly shutdown peripherals (GPS, LED) on Heltec T114.

Fixes: meshcore-dev#1014

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
@IoTThinks
Copy link

IoTThinks commented Nov 22, 2025

Have you shutdown the LoRa too?

@fschrempf
Copy link
Contributor

fschrempf commented Nov 22, 2025

@yarda This is great! I recently provided this PR and it already has been tested on some devices with good results. I totally missed that there is a global instance of the radio_driver so I could actually call sleep() from the companion app code. That's what I've been looking for.

@fschrempf fschrempf mentioned this pull request Nov 22, 2025
Open
@fschrempf
Copy link
Contributor

fschrempf commented Nov 22, 2025 •
edited
Loading

@yarda I've integrated your changes in #1122 keeping your authorship. I hope this is ok for you.

I also changed it so, it always calls into sleep() as RadioLib should have it implemented for all modules. If it is not supported it will be a nop already in the lib.

@fschrempf
Copy link
Contributor

fschrempf commented Nov 22, 2025

If @yarda agrees, we can close this in favor of #1122.

@yarda yarda mentioned this pull request Nov 22, 2025
Open
@yarda
Copy link
Author

yarda commented Nov 22, 2025

@fschrempf thanks LGTM, closing.

@yarda yarda closed this Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Current to high generally in hibernating(turned off state)

3 participants

@yarda @IoTThinks @fschrempf