-
Notifications
You must be signed in to change notification settings - Fork 161
feat(registry): Populate createdAt in model metadata #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(registry): Populate createdAt in model metadata #809
Conversation
Signed-off-by: Yash Kumar Gupta <yashkr104@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AuraReaper, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates a createdAt timestamp into model metadata within the meshkit repository. This change is part of a broader, multi-repository effort to standardize the inclusion of creation timestamps for model definitions. By populating this field at the point of model metadata initialization, the PR ensures that all model definitions are consistently stamped with their creation time, improving data consistency and providing a historical record for each model.
Highlights
- Populate
createdAtin Model Metadata: ThecreatedAttimestamp is now consistently populated inModelDefinition_Metadataacross various locations where model metadata is initialized or updated. This ensures that all model definitions include a creation timestamp, enhancing data traceability. - Dependency Update: The
go.modandgo.sumfiles have been updated to reflect a minor version bump for theoapi-codegen/runtimedependency fromv1.1.1tov1.1.2.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request consistently populates the createdAt field in ModelDefinition_Metadata across various parts of the codebase, which is a good enhancement for tracking model creation. The implementation is correct in all instances. My main feedback is to address the code duplication for metadata initialization by introducing a constructor function in the meshery/schemas repository. This would improve long-term maintainability.
Signed-off-by: Yash Kumar Gupta <yashkr104@gmail.com>
Signed-off-by: Yash Kumar Gupta <yashkr104@gmail.com>
|
This PR's depends on the changes made in the schema repo so i think that should be merged first in-order for changes in this repo to take place |
Signed-off-by: Yash Kumar Gupta <yashkr104@gmail.com>
Description
This PR fixes meshery/meshery#15021
Notes for Reviewers
This PR is part of a multi-repo change to add a
createdAttimestamp to model metadata. It depends on the changes in theschemasrepository PR linked below.This change updates the
meshkitrepository to populate the newcreatedAtfield in the model metadata.Changes:
ModelDefinition_Metadatais created to populate thecreatedAtfield.Signed commits