Fix limit order API examples and documentation #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes critical inaccuracies in limit order API examples and documentation across all languages (Go, Python, Java).
Changes
API Example Corrections
All Languages (Go, Python, Java):
limit_orders/{id}(not nested under groups/accounts)ownerfield toCreateLimitOrderListLimitOrdersandSearchLimitOrderspage_size,page_token, ornext_page_token(these don't exist in protobuf)SearchLimitOrdersfilters to only use:token,account,live_ledger_dataMonitorLimitOrderto use oneof identifier (name OR external_reference)CancelLimitOrderreturn type (returnsLimitOrder, not response wrapper)LIMIT_ORDER_STATUS_COMPLETE(notFILLEDorPARTIALLY_FILLED)Go-specific:
type_v1import to create exampleEnhanced Monitoring Patterns
monitor-limit-order examples:
monitorOrder:) for clean exitSUBMISSION_IN_PROGRESS,COMPLETE_IN_PROGRESS,CANCELLATION_IN_PROGRESScreate-limit-order examples:
OPENstatusSUBMISSION_FAILEDwith errorcancel-limit-order examples:
CANCELLEDstatusCANCELLATION_IN_PROGRESS→CANCELLEDtransitionDocumentation Fixes (index.mdx)
MonitorLimitOrderuses oneof (not multiple filters)ownerfield and monitoringVerification
All changes verified against protobuf definitions:
proto/meshtrade/trading/limit_order/v1/service.protoproto/meshtrade/trading/limit_order/v1/limit_order.protoTest Plan
LimitOrderStatusenumFiles Modified
🤖 Generated with Claude Code