Cms

[meshy]

No description provided.

[coveralls]

Coverage remained the same when pulling 8464f99 on cms into accdec8 on master.

[meshy]

nav_tree.urls need integration tests, and cms.urls needs unit tests.

[meshy]

Incomplete

[meshy]

This PR too big -- will have to remove the nav_tree stuff for the moment

[coveralls]

Coverage remained the same when pulling d35c0d5 on cms into accdec8 on master.

[coveralls]

Coverage decreased (-0.56%) when pulling e00a42b on cms into accdec8 on master.

[kevinetienne]

Looks good, do you think it worth adding a test for app_url in cms/urls?

[meshy]

Yeah, definitely. I've got a half-built test at home, so I'll commit it tonight

Thanks for having a look :)

[meshy]

(Don't want to lose that 100% coverage!)

[coveralls]

Coverage remained the same when pulling 8445d49 on cms into accdec8 on master.

[meshy]

Please review!

[kevinetienne]

wondering if this should be an AttributeError?

[meshy]

No.

exception AttributeError

Raised when an attribute reference (see Attribute references) or assignment fails. (When an object does not support attribute references or attribute assignments at all, TypeError is raised.)

exception ValueError

Raised when a built-in operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError.

[kevinetienne]

Fair enough, I was thinking as cms_urls is an attribute it could have make sense

[meshy]

Sorry -- I just re-read that, and I came across really harsh, sorry! 🍰

[kevinetienne]

not at all, don't worry :)

[meshy]

👍

[meshy]

Thank you! :)