-
Notifications
You must be signed in to change notification settings - Fork 2
Update for django 1.8 #44
Conversation
|
I was thinking that Django might have a method to query the non-related fields and related fields separately which might have helped here but I didn't find anything relevant here. |
|
I think that |
|
That said, I can't help but question the use of the test now. |
|
Perhaps |
|
Sounds like a plan. |
|
Alternatively, is there a better way to create the subclasses we're testing? |
|
@ian-foote |
|
Ah, that's a pity. |
The fields refer to incoming foreign keys from subclasses that appear in other tests.
|
I added the new fields to what the test expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the slug.help_text is correctly defined. Perhaps it should be using textwrap.dedent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think you're right, this is odd. Really, it should just be one line, as that's how I am expecting it to appear in the admin.
|
\o/ |
There's a failing test related to testing the fields on Route.
In django 1.8 we seem to be getting the related names of models that were created in other test methods.