This repository was archived by the owner on Apr 16, 2023. It is now read-only.
Add checks for common installation mistakes #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
There was a problem hiding this comment.
This works, but I don't know how I can test it. I'm wondering if there's a better way.
Owner
There was a problem hiding this comment.
Perhaps __subclasses__ can be mocked?
conman/routes/tests/test_checks.py
Outdated
Owner
There was a problem hiding this comment.
I think that this should be two test classes -- one for each check.
Owner
|
This is fantastic -- thanks :) |
Owner
|
👍 Happy for me to merge? |
LilyFirefly
pushed a commit
that referenced
this pull request
Aug 2, 2015
Add checks for common installation mistakes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.