Add docker structure #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mesilov
commented
Oct 6, 2024
mesilov
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | Fix #6 ... |
| License | MIT |
Add docker containers
Added a PHP CLI service definition in `docker-compose.yaml` and created the appropriate Dockerfile. Enhanced Composer dependencies and updated Makefile with new commands for initializing and managing the application containers. Updated `.gitignore` to exclude Docker database files. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
mesilov
commented
Oct 6, 2024
Owner
Author
|
@KarlsonComplete забирает актуальную версию веточки и открывает PR на неё из своей |
Updated the Bitrix24Account class with UUID and member ID properties, leveraging Symfony and Doctrine annotations. Additionally, replaced the deprecated SDK package and adjusted the PHPUnit testsuite configuration. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
mesilov
commented
Oct 6, 2024
camaxtly
reviewed
Oct 6, 2024
Removed custom Docker configurations for nginx, PHP-FPM, and PostgreSQL to streamline the Docker environment. Introduced a centralized environment configuration using .env and Symfony Dotenv. Additionally, refactored the Bitrix24Account entity and its repository to enhance code maintainability and align with best practices. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Added /docker/postgres directory to the .gitignore file to prevent it from being tracked by Git. This ensures that local PostgreSQL database files are not included in the repository. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
This change integrates the Bitrix24AccountRepository with the Bitrix24Account entity. The repository will handle database interactions specific to Bitrix24Account instances. This update enhances the modularity and maintainability of the codebase. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Introduced `Bitrix24AccountRepositoryTest` to ensure the repository's correct functionality. Modified the Makefile to run the functional tests suite with more detailed output including warnings. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
The /docker/postgres directory is no longer required to be ignored by Git. This change ensures that any important files in this directory can now be tracked and versioned. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Standardize usage of EntityManagerInterface and improve type inconsistencies. Apply `#[Override]` attribute in tests, and add null checks and validation for better robustness. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Replaced the 'make lint-phpstan' command with a direct call to 'vendor/bin/phpstan --memory-limit=2G analyse.' This change ensures better control over memory usage and eliminates the dependency on the Makefile. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Replaced `make lint-rector` with `vendor/bin/rector process --dry-run` for better control and customization of the Rector tool in CI pipeline. This change ensures a direct invocation of Rector with specified options without intermediary make tasks. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Add a new GitHub workflow for functional tests with specified environments and steps. Update `docker-compose.yaml` to reflect the new PostgreSQL database settings. Rename existing workflows for clarity and consistency. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Replaced the "make test-unit" command with a direct call to phpunit in the GitHub Actions workflow for better clarity and control over the test execution. This change uses the phpunit command with options for test suite, warnings, and formatted output. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Modified the functional test workflow to drop and recreate the database schema before running tests. This ensures a consistent test environment and improves test reliability. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Changed the environment variable names from POSTGRES_* to DATABASE_* in the tests-functional.yml file. This ensures consistency with other parts of the project and provides more descriptive variable names. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Include essential environment variables for the PostgreSQL database setup within the functional test GitHub Actions workflow. This ensures the tests have access to the correct database credentials. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Implemented commands and handlers for InstallStart, InstallFinish, Uninstall, ChangeDomainUrl, and RenewAuthToken use cases. Added testing and improved event handling in Bitrix24Account class. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
- Правки для сs fixer
Add docker structure
camaxtly
reviewed
Feb 2, 2025
tests/Unit/Bitrix24Accounts/UseCase/ChangeDomainUrl/CommandTest.php
Outdated
Show resolved
Hide resolved
camaxtly
reviewed
Feb 2, 2025
camaxtly
reviewed
Feb 2, 2025
camaxtly
reviewed
Feb 2, 2025
camaxtly
reviewed
Feb 2, 2025
camaxtly
reviewed
Feb 2, 2025
camaxtly
reviewed
Feb 2, 2025
tests/Functional/Bitrix24Accounts/Builders/Bitrix24AccountBuilder.php
Outdated
Show resolved
Hide resolved
camaxtly
reviewed
Feb 2, 2025
camaxtly
reviewed
Feb 2, 2025
- В тестах поправил создание команды
…licationVersion - Юзанул cs-fixer - Юзанул ректор - Добавлена сущность Domain
Add docker structure
camaxtly
reviewed
Feb 9, 2025
camaxtly
reviewed
Feb 9, 2025
camaxtly
reviewed
Feb 9, 2025
tests/Unit/Bitrix24Accounts/UseCase/ChangeDomainUrl/CommandTest.php
Outdated
Show resolved
Hide resolved
camaxtly
reviewed
Feb 9, 2025
camaxtly
reviewed
Feb 9, 2025
- Пофиксил юнит тесты на проверки и на домен
Add docker structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.