Skip to content

Conversation

@dnicolodi
Copy link
Member

No description provided.

@dnicolodi
Copy link
Member Author

@rgommers Do you know anything about the integration of codecov into the github project? I think that as we upload the coverage reports to codecov we may as well have codecov report back the coverage report as a status check on the pull requests. However, the status checks do not appear. I've been reading the codecov documentation. AFAIU, status checks should be enabled by default

@rgommers
Copy link
Contributor

rgommers commented Sep 4, 2023

It used to appear in status checks, see e.g. #165 (comment). That also discusses informational: true. Codecov status checks are somewhat useful indeed on occasion, as long as their bot doesn't comment and it never fails.

It looks like it disappeared when we migrated the repo to the mesonbuild org. The GitHub App isn't installed on this repo. The status checks are visible on Meson PRs, so I don't think there's a security concern with it (despite Codecov not exactly being the most reliable provider - multiple security issues).

I don't have permissions to install the App, but I was able to send a request for it - once it's approved by a mesonbuild org admin the problem should be fixed.

@rgommers rgommers added the CI Continuous Integration label Sep 4, 2023
@dnicolodi
Copy link
Member Author

Thanks @rgommers

Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cleanups LGTM, thanks.

@rgommers rgommers merged commit bf3d0f7 into mesonbuild:main Sep 4, 2023
@dnicolodi
Copy link
Member Author

I wanted to make sure that the codecov reports are sensible before merging. But we can tweak the configuration further later, if needed.

@rgommers
Copy link
Contributor

rgommers commented Sep 4, 2023

Yeah, I figured this is almost certainly right, and the cleanups are useful. We can tweak it later if needed.

@cclauss
Copy link
Contributor

cclauss commented Aug 2, 2024

There are a lot of Codecov: Failed to properly create commit warnings in GitHub Actions runs like at the bottom right of
https://github.com/mesonbuild/meson-python/actions/runs/10213496455

@rgommers
Copy link
Contributor

rgommers commented Aug 2, 2024

https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes - a token is needed with v4 of the action. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants