-
Notifications
You must be signed in to change notification settings - Fork 81
CI: update codecov action #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rgommers Do you know anything about the integration of codecov into the github project? I think that as we upload the coverage reports to codecov we may as well have codecov report back the coverage report as a status check on the pull requests. However, the status checks do not appear. I've been reading the codecov documentation. AFAIU, status checks should be enabled by default |
|
It used to appear in status checks, see e.g. #165 (comment). That also discusses It looks like it disappeared when we migrated the repo to the I don't have permissions to install the App, but I was able to send a request for it - once it's approved by a |
|
Thanks @rgommers |
rgommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These cleanups LGTM, thanks.
|
I wanted to make sure that the codecov reports are sensible before merging. But we can tweak the configuration further later, if needed. |
|
Yeah, I figured this is almost certainly right, and the cleanups are useful. We can tweak it later if needed. |
|
There are a lot of |
|
https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes - a token is needed with v4 of the action. I'll have a look. |
No description provided.