Ack ElasticSearch 5.0 changes regarding heap size #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heap size in ElasticSearch 5.0 now come from the env var "ES_JAVA_OPTS", as opposed to the old "JAVA_OPTS". This change strives for better compatibility with other ElasticSearch versions, and acks ES_JAVA_OPTS as one of the options of setting the heap size.
|
Can one of the admins verify this patch? |
|
LGTM Thanks for your contrubution @nubunto! |
|
Since yesterday, I have found some low hanging fruit that makes this change a breaking change, @frankscholten. I'm commiting it right now, but I think that we probably want to revert this. |
|
And for full backwards compatibility, I would like to discuss a way of getting at the ES version at configuration time. |
|
Ok, I reverted the commits. Let me know when we can merge again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heap size in ElasticSearch 5.0 now come from the env var
"ES_JAVA_OPTS", as opposed to the old "JAVA_OPTS". This change strives
for better compatibility with other ElasticSearch versions, and acks
ES_JAVA_OPTS as one of the options of setting the heap size.