Updates conversations API with recent features. #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@olimpias Can you review this conversation related PR when you have time? I will also check tests etc. |
denizkilic
reviewed
Oct 1, 2020
olimpias
reviewed
Oct 1, 2020
api/src/main/java/com/messagebird/objects/conversations/ConversationMessage.java
Show resolved
Hide resolved
Contributor
|
If you have time, you can add Email Object to content as well. Here Doc: https://developers.messagebird.com/api/conversations/#email-object |
* Some minor fixes over the last commit.
Author
|
Added email content as well, reflected comments. |
denizkilic
reviewed
Oct 8, 2020
api/src/main/java/com/messagebird/objects/MessageReference.java
Outdated
Show resolved
Hide resolved
denizkilic
reviewed
Oct 8, 2020
api/src/main/java/com/messagebird/objects/conversations/ConversationContentEmail.java
Outdated
Show resolved
Hide resolved
denizkilic
reviewed
Oct 8, 2020
api/src/main/java/com/messagebird/objects/conversations/ConversationContentEmail.java
Show resolved
Hide resolved
* Adds accessor and toString to ConversationContentEmail.
Contributor
|
Hi @mehmetminanc , in Note: I tried to push the changes but I didn't have permission to push our your branch :) |
Contributor
|
@mehmetminanc to make this faster, cem will add enum it another PR, no need to do anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to reflect new Conversations features in the client.
Testing
mvn testThere is a curious issue with my local mvn runner:
This doesn't occur with IntelliJ Test Runner - set to Java 1.8 (OpenJDK).
mvn package