Skip to content

Conversation

@marcelcorso
Copy link
Contributor

No description provided.

@samwierema
Copy link
Contributor

Are the constants defined in src/MessageBird/Objects/Lookup.php used?

@marcelcorso
Copy link
Contributor Author

No. They are not used. I saw that other "Objects" defined constants so I tried to be consistent. I think it can help users too.

@samwierema
Copy link
Contributor

Ah, you're right. That is something we'd probably need to review later.

@samwierema
Copy link
Contributor

Can you rename LookupHLR to LookupHlr (filename and class name)?

samwierema added a commit that referenced this pull request Dec 16, 2015
Adding the new Lookup API endpoints
@samwierema samwierema merged commit 9e9cc56 into master Dec 16, 2015
@samwierema samwierema deleted the lookup branch December 16, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants