Skip to content

Add missing details hlr attribute #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2016
Merged

Add missing details hlr attribute #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b85c3a5
Add missing details parameter to HLR object.
bviolier Feb 1, 2016
e322a3b
Details should be an array + change test accordingly.
bviolier Feb 1, 2016
9fe2d2d
[] is not supported in PHP5.3
bviolier Feb 1, 2016
67e5194
Fix HLR test
bviolier Feb 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/MessageBird/Objects/Hlr.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ class Hlr extends Base
*/
public $network;

/**
* A array with extra HLR information. Do note that the attributes in the array can change over time and
* can be null (not all information is availble for all countries and providers).
*
* @var array
*/
public $details = array();

/**
* A client reference. Here you can put your own reference,
* like your internal reference.
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/hlr/HlrTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function testCreateHlr()
$Hlr->msisdn = 'MessageBird';
$Hlr->reference = "yoloswag3000";

$this->mockClient->expects($this->once())->method('performHttpRequest')->with("POST", 'hlr', null, '{"msisdn":"MessageBird","network":null,"reference":"yoloswag3000","status":null}');
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("POST", 'hlr', null, '{"msisdn":"MessageBird","network":null,"details":[],"reference":"yoloswag3000","status":null}');
$this->client->hlr->create($Hlr);
}

Expand Down