Reformating and minor changes #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed endpoint, some reformating at tests
Changed version to 1.5.0
Added chat related properties to Client class.
composer.json
Outdated
| "name": "messagebird/php-rest-api", | ||
| "description": "MessageBird REST API client for PHP", | ||
| "version": "1.4.1", | ||
| "version": "1.5.0", |
Contributor
There was a problem hiding this comment.
I think this field is unnecessary. @samwierema had problems until he removed this
Contributor
There was a problem hiding this comment.
Yeah, we can remove this. As mentioned in the Composer documentation for the version tag:
Optional if the package repository can infer the version from somewhere, such as the VCS tag name in the VCS repository. In that case it is also recommended to omit it.
removed version from composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$endpoint,loadfromArray()