Skip to content

Fix optional type details #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samwierema merged 2 commits into from
Mar 24, 2017
Merged

Fix optional type details #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3401365
Update `setPremiumSms` so optional fields are not required, add `member`
Mar 13, 2017
a2d7aca
Bump version
Mar 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MessageBird/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Client
const ENDPOINT = 'https://rest.messagebird.com';
const CHATAPI_ENDPOINT = 'https://chat.messagebird.com/1';

const CLIENT_VERSION = '1.6.3';
const CLIENT_VERSION = '1.6.4';

/**
* @var string
Expand Down
10 changes: 8 additions & 2 deletions src/MessageBird/Objects/Message.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,19 @@ class Message extends Base
* @param $keyword
* @param $tariff
* @param $mid
* @param $member
*/
public function setPremiumSms($shortcode, $keyword, $tariff, $mid)
public function setPremiumSms($shortcode, $keyword, $tariff, $mid = null, $member = null)
{
$this->typeDetails['shortcode'] = $shortcode;
$this->typeDetails['keyword'] = $keyword;
$this->typeDetails['tariff'] = $tariff;
$this->typeDetails['mid'] = $mid;
if ($mid != null) {
$this->typeDetails['mid'] = $mid;
}
if ($member != null) {
$this->typeDetails['member'] = $member;
}

$this->type = self::TYPE_PREMIUM;
}
Expand Down