Skip to content

Conversation

@chrisminett
Copy link
Contributor

The value from $_SERVER['HTTP_MESSAGEBIRD_REQUEST_TIMESTAMP'] is a numeric string, but an int is expected by the validation in SignedRequest::loadFromArray()

Fixes #87

The value from $_SERVER is a numeric string, but an int is expected by the validation.
Fixes messagebird#87
Copy link
Contributor

@modprobe modprobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marcelcorso marcelcorso merged commit 30739d8 into messagebird:master Jun 11, 2019
@chrisminett chrisminett deleted the signedrequest-date-int branch June 11, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignedRequest->createFromGlobals() does not set requestTimestamp to integer

3 participants