This repository was archived by the owner on Aug 23, 2019. It is now read-only.
Update dateformat to the latest version 🚀 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Version 3.0.1 just got published. |
Author
Version 3.0.2 just got published. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0.0 of dateformat just got published.
The version 3.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of dateformat.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
3.0.0Allows AM/PM indicators to be localized.
As this requires an extra field in dateFormat.i18n it becomes a breaking change for anyone localizing the names.
Commits
The new version differs by 9 commits.
4944c413.0.09df09d02.1.0e1ef798Merge pull request #60 from hooriza/masteraf44ce9Merge pull request #69 from shamrin/patch-1a7dbb3cno need to mention standalone function any more61e5721Merge pull request #63 from felixonmars/patch-1ecb1069Fix a typo: occured -> occurred85f031cadd i18n.timeNames for AM, PM589d377Merge pull request #53 from jonschlinkert/masterSee the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴