Skip to content

Update feedback count func #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

Update feedback count func #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b551063
Update feeback count func
sergiopaniego Nov 17, 2025
6129b8b
Update function
sergiopaniego Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/envs/textarena_env/rewards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,18 @@ def extract_feedback_counts(feedback: str) -> Tuple[int, int]:
if not feedback:
return (0, 0)

segments = [
segment.strip() for segment in feedback.split("\n\n") if segment.strip()
]
if not segments:
lines = [line.strip() for line in feedback.split("\n") if line.strip()]
if len(lines) < 2:
return (0, 0)

latest_segment = segments[-1]
lines = [line.strip() for line in latest_segment.splitlines() if line.strip()]
latest_line = lines[-1] if lines else latest_segment
for line in lines:
normalized = line.replace(" ", "")
if normalized and all(c in "GYX" for c in normalized):
green = normalized.count("G")
yellow = normalized.count("Y")
return (green, yellow)

green_count = latest_line.count("G")
yellow_count = latest_line.count("Y")
return (green_count, yellow_count)
return (0, 0)


class _WordleRewardProvider:
Expand Down