-
Notifications
You must be signed in to change notification settings - Fork 106
Add git server environment #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
nice!! |
examples/local_git_env.py
Outdated
| print() | ||
|
|
||
| # Create provider and start container with environment variables | ||
| provider = LocalDockerProvider() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use GitEnv.from_docker_image("git-env:latest")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires environment variables (and in general, other kwargs) to be supported by the http_env_client.py's from_docker_image method since that starts the container. I will add a kwargs argument and make this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the change. Please let me know if this looks good
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install smolagents (required by core.tools.PyExecutor, even though git_env doesn't use it directly) | ||
| RUN pip install --no-cache-dir smolagents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR but ideally, we should move smolagents a few other basic deps into base image Dockerfile. Do you mind creating an issue or a PR for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I can create an issue for this
| fi | ||
|
|
||
| # Initialize Gitea (POST to root URL) | ||
| echo "3. Initializing Gitea configuration..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,36 @@ | |||
| # Dockerfile for Git Environment | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may add this docker file in the .github/workflows/ here https://github.com/meta-pytorch/OpenEnv/blob/main/.github/workflows/docker-build.yml#L78 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Please check
|
FYI @pankit-eng we don't have write permissions, will let you merge! |
Adds Gitea-based git server environment with task-based isolation. This would be useful for containerized git server access for the agent. The server is shared between different task processes to improve scalability.
It supports