Skip to content

[4/N] Autobucketing: bucket comms from greedy algorithm decisions #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2025
Merged

[4/N] Autobucketing: bucket comms from greedy algorithm decisions #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b67f87b
Update
ruisizhang123 Sep 4, 2025
7ce6908
Update
ruisizhang123 Sep 5, 2025
d33fa3f
Update
ruisizhang123 Sep 5, 2025
7927f5e
Update
ruisizhang123 Sep 6, 2025
9a20a7f
Update
ruisizhang123 Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion autoparallel/auto_bucketing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import torch

from .autobucketing_util import bucket_plan, bucket_utils
from .autobucketing_util import bucket_func, bucket_plan, bucket_utils


class simplefsdp_autobucketing_config:
Expand Down Expand Up @@ -53,4 +53,22 @@ def simple_fsdp_autobucketing_reordering_pass(
bucketable_nodes,
configs,
)

snodes = bucket_func.bucket_fsdp_all_gather_with_plan(
scheduler,
snodes,
scheduler.name_to_buf,
scheduler.name_to_fused_node,
all_gather_plan,
bucketable_nodes,
)
if len(reduce_scatter_plan) > 0:
snodes = bucket_func.bucket_fsdp_reduce_scatter_with_plan(
scheduler,
snodes,
scheduler.name_to_buf,
scheduler.name_to_fused_node,
reduce_scatter_plan,
bucketable_nodes,
)
return snodes
Loading