Skip to content

[5/N] Autobucketing: add reordering for comm overlapping #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2025
Merged

[5/N] Autobucketing: add reordering for comm overlapping #134

merged 5 commits into from
Sep 6, 2025

Conversation

@ruisizhang123
Copy link
Contributor

@ruisizhang123 ruisizhang123 commented Sep 4, 2025 •
edited
Loading

This pr adds reordering to pre-fetch bucketed AG/RS nodes. The logic is as follows:

In forward pass:

  • reorder ag_i before wait_i-1_ag

In backward pass:

  • reorder ag_i after wait_i-1_ag
  • reorder wait_i_rs before rs_i+1

Stack from ghstack (oldest at bottom):

@ruisizhang123
Update
fe8b82e 
[ghstack-poisoned]
ruisizhang123 added a commit that referenced this pull request Sep 4, 2025
@ruisizhang123
[5/N] Autobucketing: add reordering for comm overlapping
adef140 
ghstack-source-id: e34d0d1
Pull-Request: #134
This was referenced Sep 4, 2025
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 4, 2025
@ruisizhang123 ruisizhang123 mentioned this pull request Sep 4, 2025
Merged
@ruisizhang123
Update
017b8e2 
[ghstack-poisoned]
ruisizhang123 added a commit that referenced this pull request Sep 5, 2025
@ruisizhang123
[5/N] Autobucketing: add reordering for comm overlapping
e4db491 
ghstack-source-id: 06eb2f6
Pull-Request: #134
fmassa
fmassa approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it in #138 and LGTM, thanks!

@ruisizhang123
Update
ee2ce96 
[ghstack-poisoned]
ruisizhang123 added a commit that referenced this pull request Sep 5, 2025
@ruisizhang123
[5/N] Autobucketing: add reordering for comm overlapping
2578e8e 
ghstack-source-id: e09a119
Pull-Request: #134
@ruisizhang123
Update
e91a405 
[ghstack-poisoned]
ruisizhang123 added a commit that referenced this pull request Sep 6, 2025
@ruisizhang123
[5/N] Autobucketing: add reordering for comm overlapping
6ded3c1 
ghstack-source-id: 1037b06
Pull-Request: #134
@ruisizhang123
Update
4864303 
[ghstack-poisoned]
ruisizhang123 added a commit that referenced this pull request Sep 6, 2025
@ruisizhang123
[5/N] Autobucketing: add reordering for comm overlapping
4c8502d 
ghstack-source-id: a001d97
Pull-Request: #134
@ruisizhang123 ruisizhang123 merged commit 9b1a0ad into gh/ruisizhang123/5/base Sep 6, 2025
6 checks passed
@ruisizhang123 ruisizhang123 mentioned this pull request Sep 6, 2025
Merged
@fmassa fmassa deleted the gh/ruisizhang123/5/head branch September 6, 2025 07:54
ruisizhang123 added a commit that referenced this pull request Sep 6, 2025
@ruisizhang123
[Autobucketing] Add simplefsdp's autobucketing pass to autoparallel (#…
d2ba202 
…141)

* Update (base update)

[ghstack-poisoned]

* Update (base update)

[ghstack-poisoned]

* Update (base update)

[ghstack-poisoned]

* Update (base update)

[ghstack-poisoned]

* Update (#134)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ruisizhang123 @fmassa