Expanding on docstrings for approximate_gp and fully_bayesian #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 122 122
Lines 10778 10778
=======================================
Hits 10777 10777
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Contributor
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dme65
approved these changes
Aug 2, 2022
Contributor
dme65
left a comment
dme65
left a comment
There was a problem hiding this comment.
Thanks for improving our documentation! I rewrote a few sentences, but lgtm otherwise!
Co-authored-by: David Eriksson <dme65@cornell.edu>
Contributor
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I am making several PRs each expanding on model documentation. I am trying to identify the best subject-matter experts for each as a reviewer. In this case this is @dme65 , especially for the fully Bayesian models; let me know if someone else should review the variational models.
this is the last docstring PR!
Motivation
Make it easier for people to understand what the different models do and figure out which one is right for their use case
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
#1327, #1328 , #1329