Removing _fit_multioutput_independent and allclose_mll.
#1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42071480 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42071480 |
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 153 153
Lines 13562 13527 -35
=========================================
- Hits 13562 13527 -35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42071480 |
Summary: Pull Request resolved: #1570 The original bug that motivated fitting certain types of multioutput models independently has been resolved, so `_fit_multioutput_independent` is no longer needed. Reviewed By: Balandat Differential Revision: D42071480 fbshipit-source-id: f1f6d3f2212344243ba5ad4c3bb8d9e5f7007aa6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42071480 |
Contributor
|
This pull request has been merged in 466aaf9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The original bug that motivated fitting certain types of multioutput models independently has been resolved, so
_fit_multioutput_independentis no longer needed.Reviewed By: Balandat
Differential Revision: D42071480