botorch.qmc -> botorch.sampling, move MCSamplers there #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Balandat
force-pushed
the
export-D15808512
branch
from
98bc0fb to
9cfd8aa
Compare
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Jun 13, 2019
) Summary: Pull Request resolved: meta-pytorch#172 The MCSamplers currently live in the acquisition module. There is no real reason for that. It also causes issues with circular imports when trying to make fantasizing a part of the Model API. This diff renames `botorch.qmc` to `botorch.sampling` (since this now does more than just qmc), and moves the samplers into this module. Note that these are breaking changes that need to be surfaced in the release notes. Differential Revision: D15808512 fbshipit-source-id: 2ecf2489583b843afec9d94c36bb224146db7bd6
) Summary: Pull Request resolved: meta-pytorch#172 The MCSamplers currently live in the acquisition module. There is no real reason for that. It also causes issues with circular imports when trying to make fantasizing a part of the Model API. This diff renames `botorch.qmc` to `botorch.sampling` (since this now does more than just qmc), and moves the samplers into this module. Note that these are breaking changes that need to be surfaced in the release notes. Differential Revision: D15808512 fbshipit-source-id: 3456459277876eba4f1022ccec686793b9aba145
Balandat
force-pushed
the
export-D15808512
branch
from
9cfd8aa to
b50729f
Compare
Contributor
|
This pull request has been merged in e9ec5d2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The MCSamplers currently live in the acquisition module. There is no real reason for that.
It also causes issues with circular imports when trying to make fantasizing a part of the Model API.
This diff renames
botorch.qmctobotorch.sampling(since this now does more than just qmc), and moves the samplers into this module.Note that these are breaking changes that need to be surfaced in the release notes.
Differential Revision: D15808512