Skip to content

Conversation

@bkarrer
Copy link
Contributor

@bkarrer bkarrer commented Jun 24, 2019

Summary: We write SingleTaskMultiFidelityGP as a subclass of SingleTaskGP to deal with GP models that have fidelity parameters. The kernel used in this new GP model comes from Section 5.3 of https://arxiv.org/abs/1903.04703. We also added mean_module and covar_module kwargs to the SingleTaskGP constructor that default to None.

Differential Revision: D15731799

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 24, 2019
@bkarrer bkarrer force-pushed the export-D15731799 branch from 0aa03cf to ae17ab9 Compare June 25, 2019 16:18
bkarrer pushed a commit to bkarrer/botorch that referenced this pull request Jun 25, 2019
Summary:
Pull Request resolved: meta-pytorch#181

We write SingleTaskMultiFidelityGP as a subclass of SingleTaskGP to deal with GP models that have fidelity parameters. The kernel used in this new GP model comes from Section 5.3 of https://arxiv.org/abs/1903.04703. We also added mean_module and covar_module kwargs to the SingleTaskGP constructor that default to None.

Differential Revision: D15731799

fbshipit-source-id: a471ad50e57fadb0f97785df3b27cfbb4913f039
@bkarrer bkarrer force-pushed the export-D15731799 branch from ae17ab9 to 9c7522c Compare June 26, 2019 18:10
bkarrer pushed a commit to bkarrer/botorch that referenced this pull request Jun 26, 2019
Summary:
Pull Request resolved: meta-pytorch#181

We write SingleTaskMultiFidelityGP as a subclass of SingleTaskGP to deal with GP models that have fidelity parameters. The kernel used in this new GP model comes from Section 5.3 of https://arxiv.org/abs/1903.04703. We also added mean_module and covar_module kwargs to the SingleTaskGP constructor that default to None.

Differential Revision: D15731799

fbshipit-source-id: 255552b7e425d3ffb43d510a439acd134303a125
@bkarrer bkarrer force-pushed the export-D15731799 branch from 9c7522c to 56fa423 Compare June 27, 2019 14:14
bkarrer pushed a commit to bkarrer/botorch that referenced this pull request Jun 27, 2019
Summary:
Pull Request resolved: meta-pytorch#181

We write SingleTaskMultiFidelityGP as a subclass of SingleTaskGP to deal with GP models that have fidelity parameters. The kernel used in this new GP model comes from Section 5.3 of https://arxiv.org/abs/1903.04703. We also added mean_module and covar_module kwargs to the SingleTaskGP constructor that default to None.

Differential Revision: D15731799

fbshipit-source-id: e2c31ca0e4066ed42b77350223b1555dd98e0fe2
@bkarrer bkarrer force-pushed the export-D15731799 branch from 56fa423 to bef4192 Compare June 27, 2019 16:30
bkarrer pushed a commit to bkarrer/botorch that referenced this pull request Jun 27, 2019
Summary:
Pull Request resolved: meta-pytorch#181

We write SingleTaskMultiFidelityGP as a subclass of SingleTaskGP to deal with GP models that have fidelity parameters. The kernel used in this new GP model comes from Section 5.3 of https://arxiv.org/abs/1903.04703. We also added mean_module and covar_module kwargs to the SingleTaskGP constructor that default to None.

Differential Revision: D15731799

fbshipit-source-id: 4a1b3bc0ca8ba7f684272e283322bcfe97d12472
@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #181 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #181   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          58     60    +2     
  Lines        2021   2062   +41     
=====================================
+ Hits         2021   2062   +41
Impacted Files Coverage Δ
botorch/models/fidelity/gp_regression_fidelity.py 100% <100%> (ø)
botorch/models/gp_regression.py 100% <100%> (ø) ⬆️
botorch/models/fidelity/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3910976...f6a3f57. Read the comment docs.

Summary:
Pull Request resolved: meta-pytorch#181

We write SingleTaskMultiFidelityGP as a subclass of SingleTaskGP to deal with GP models that have fidelity parameters. The kernel used in this new GP model comes from Section 5.3 of https://arxiv.org/abs/1903.04703. We also added mean_module and covar_module kwargs to the SingleTaskGP constructor that default to None.

Reviewed By: Balandat

Differential Revision: D15731799

fbshipit-source-id: 0ad6fbed9e26301ff7a08096208c45888e8bdf8d
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b77590c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants