update test functions to use negative indexing #757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 6987 6987
=========================================
Hits 6987 6987
Continue to review full report at Codecov.
|
Balandat
approved these changes
Mar 31, 2021
Contributor
Balandat
left a comment
Balandat
left a comment
There was a problem hiding this comment.
great, thanks for this PR!
Contributor
|
@Balandat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the existing implementation, some test functions do not support evaluations with
Xhaving multi-dimbatch_shape, e.g.,X.shape = [2, 3, d]. This PR updates the implementation of such test functions to use negative indexing, thus supporting multi-dimbatch_shape.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Extended test coverage by adding
batch_shape = [2, 3]inBaseTestProblemBaseTestCase.test_forward(). Made sure that the updated implementation agrees with the function definitions in https://www.sfu.ca/~ssurjano/optimization.html.