Make raw_samples optional.
#801
Conversation
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 106 106
Lines 7514 7516 +2
=======================================
+ Hits 7513 7515 +2
Misses 1 1
Continue to review full report at Codecov.
|
|
@vishwakftw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@vishwakftw has updated the pull request. You must reimport the pull request before landing. |
|
@vishwakftw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Balandat
left a comment
Balandat
left a comment
There was a problem hiding this comment.
some nits, test coverage
Summary: If `batch_initial_conditions` is passed, there is no need to set `raw_samples` as this argument is only used for the underlying initialization strategy when `batch_initial_condition` is `None`. Pull Request resolved: #801 Test Plan: Expect current tests to pass without issue. Differential Revision: D28579215 Pulled By: vishwakftw fbshipit-source-id: c417ce0e7b83a8c53dac3062f5589fb440f66470
|
This pull request was exported from Phabricator. Differential Revision: D28579215 |
|
@vishwakftw merged this pull request in a3df8ce. |
4 participants
If
batch_initial_conditionsis passed, there is no need to setraw_samplesas this argument is only used for the underlying initialization strategy whenbatch_initial_conditionisNone.Test Plan:
Expect current tests to pass without issue.