Refactor HOGP Posterior for memory efficiency #883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29937300 |
wjmaddox
pushed a commit
to wjmaddox/botorch
that referenced
this pull request
Jul 28, 2021
Summary: Pull Request resolved: meta-pytorch#883 refactors existing HOGP posterior to use forwards calls and to use cat_rows on the data joint covariance. Differential Revision: D29937300 fbshipit-source-id: 81aa5c9b639e030a947c8b4946f4b81024c8e2b7
wjmaddox
force-pushed
the
export-D29937300
branch
from
8c77be3 to
00506ef
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29937300 |
wjmaddox
pushed a commit
to wjmaddox/botorch
that referenced
this pull request
Jul 28, 2021
Summary: Pull Request resolved: meta-pytorch#883 refactors existing HOGP posterior to use forwards calls and to use cat_rows on the data joint covariance. Differential Revision: D29937300 fbshipit-source-id: 82ff9be65247fc019bc58d973474793d3d1ed4b3
wjmaddox
force-pushed
the
export-D29937300
branch
from
00506ef to
e7fba29
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29937300 |
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 8113 8102 -11
=========================================
- Hits 8113 8102 -11
Continue to review full report at Codecov.
|
Contributor
|
@wjmaddox has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
wjmaddox
added a commit
to wjmaddox/botorch
that referenced
this pull request
Jul 30, 2021
Summary: refactors existing HOGP posterior to use forwards calls and to use cat_rows on the data joint covariance. Pull Request resolved: meta-pytorch#883 Differential Revision: D29937300 Pulled By: wjmaddox fbshipit-source-id: def55ebf83e9afa50d515c9fb5ad2457af90ca6f
wjmaddox
force-pushed
the
export-D29937300
branch
from
3557321 to
0b0ab02
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29937300 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29937300 |
wjmaddox
added a commit
to wjmaddox/botorch
that referenced
this pull request
Aug 2, 2021
Summary: refactors existing HOGP posterior to use forwards calls and to use cat_rows on the data joint covariance. Pull Request resolved: meta-pytorch#883 Test Plan: unit tests. Differential Revision: D29937300 Pulled By: wjmaddox fbshipit-source-id: 14863186d95d4e92f79f8b1f3700ed9446202a9c
wjmaddox
force-pushed
the
export-D29937300
branch
from
0b0ab02 to
ad75389
Compare
Summary: refactors existing HOGP posterior to use forwards calls and to use cat_rows on the data joint covariance. Pull Request resolved: meta-pytorch#883 Test Plan: unit tests. Reviewed By: Balandat Differential Revision: D29937300 Pulled By: wjmaddox fbshipit-source-id: a32b81de9c55d013747b5c4b538c8e7b09e70f98
wjmaddox
force-pushed
the
export-D29937300
branch
from
ad75389 to
bb8a4d3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29937300 |
Contributor
Contributor
|
@wjmaddox, |
Contributor
Author
|
Ugh, that should have been resolved in gpytorch #1714 (cornellius-gp/gpytorch#1714); try rebasing off gpytorch master. |
Contributor
|
Yeah, my bad. Looks like I was missing that locally. Thanks for clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: refactors existing HOGP posterior to use forwards calls and to use cat_rows on the data joint covariance.
Differential Revision: D29937300