Adding isort #310
Adding isort #310
Conversation
captum/insights/api.py
Outdated
| for inputs, additional_forward_args, label in _batched_generator( | ||
| # Type ignore for issue with passing union to function taking generic | ||
| # https://github.com/python/mypy/issues/1533 | ||
| for inputs, additional_args, label in _batched_generator( # type: ignore |
There was a problem hiding this comment.
These changes were necessary to fix mypy failures on master due to merging with the common type hints. additional_forward_args was renamed to additional_args since the "type: ignore" made the line too long causing flake8 errors.
CC: @edward-io
There was a problem hiding this comment.
could we do:
for (
inputs,
additional_forward_args,
label,
) in _batched_generator( # type: ignore
instead?
There was a problem hiding this comment.
Sure, I figured a single line is more concise, but this works too, will update, thanks!
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
edward-io
left a comment
edward-io
left a comment
There was a problem hiding this comment.
Looks good to me, though I didn't review all 86 files. Minor comments, LGTM.
captum/insights/api.py
Outdated
| for inputs, additional_forward_args, label in _batched_generator( | ||
| # Type ignore for issue with passing union to function taking generic | ||
| # https://github.com/python/mypy/issues/1533 | ||
| for inputs, additional_args, label in _batched_generator( # type: ignore |
There was a problem hiding this comment.
could we do:
for (
inputs,
additional_forward_args,
label,
) in _batched_generator( # type: ignore
instead?
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This applies isort to alphabetize import ordering. We also add an isort check to CircleCI to ensure that import ordering is maintained in future PRs. This required adding an isort config that is compatible with black, which was found here: https://github.com/psf/black This also adds a type: ignore for an issue caused by merging Insights type fixes with type hints for common. Pull Request resolved: meta-pytorch#310 Reviewed By: orionr Differential Revision: D20206324 Pulled By: vivekmig fbshipit-source-id: 48cce82d60a9a6f7384211e7aae2ffb4c0c85772
3 participants
This applies isort to alphabetize import ordering. We also add an isort check to CircleCI to ensure that import ordering is maintained in future PRs. This required adding an isort config that is compatible with black, which was found here: https://github.com/psf/black
This also adds a type: ignore for an issue caused by merging Insights type fixes with type hints for common.