Use relative paths for Insights #312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0Nreynolds
approved these changes
Mar 4, 2020
Contributor
J0Nreynolds
left a comment
J0Nreynolds
left a comment
There was a problem hiding this comment.
Just had one question about the change to the package.json file.
| "name": "frontend", | ||
| "version": "0.2.0", | ||
| "private": true, | ||
| "homepage": ".", |
Contributor
There was a problem hiding this comment.
Was this necessary to get relative paths working?
Contributor
Author
There was a problem hiding this comment.
Yup, this rewrites the urls from /something.css to ./something.css, so it doesn't try to access the url root (if the app was hosted on example.com/proxy/1234/ it would correctly access it in example.com/proxy/1234/something.css instead of example.com/something.css.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@edward-io merged this pull request in 465dbaf. |
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Summary: This change allows Insights to work with [Jupyter server proxy](https://github.com/jupyterhub/jupyter-server-proxy). However, Sagemaker is broken due to https://forums.aws.amazon.com/message.jspa?messageID=914445#914445. Pull Request resolved: meta-pytorch#312 Reviewed By: vivekmig Differential Revision: D20252333 Pulled By: edward-io fbshipit-source-id: f90cfd9dab46a479319774dbf6263d75e92a9be1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows Insights to work with Jupyter server proxy.
However, Sagemaker is broken due to https://forums.aws.amazon.com/message.jspa?messageID=914445#914445.