Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for another set of flaky tests:
test_multi_inp_shapley_batch_scalar_tensor_0d,test_multi_inp_shapley_batch_scalar_floatandtest_multi_inp_shapley_batch_scalar_tensor_1dintest_shapley.py. Note thattest_multi_inp_shapley_batch_scalar_intwas not flaky to begin with.I observed that increasing
n_samplesup to 3500 reduces flakiness by a lot. This increases the runtime from about 1.7s to 4.5s though. The tests only failed about 6/7 times out of 1000 runs with only then_sampleschange. Hence, I also increased thedeltato 1.2 based on the observed failures to bring that to ~0%. Let me know in case you would prefer lowern_samplesbut higherdeltato reduce the runtime.Thanks!
cc @vivekmig