This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[bc-breaking] rename top level UX to convert_to_float8_training
#329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Old name: `swap_linear_with_float8_linear` New name: `convert_to_float8_training` Choosing a more generic name, with the following improvements from the old name: 1. doesn't mention module swaps, which is an implementation detail 2. doesn't mention `Float8Linear`, which is an implementation detail 3. clarifies that this is for training, not to be confused with inference APIs 4. doesn't mention `linear`, which gives more freedom to add other modules later ``` find . -name '*.py' -print0 | xargs -0 sed -i 's/swap_linear_with_float8_linear/convert_to_float8_training/g' ``` Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 24, 2024
vkuzo
added a commit
that referenced
this pull request
Jul 24, 2024
Summary: Old name: `swap_linear_with_float8_linear` New name: `convert_to_float8_training` Choosing a more generic name, with the following improvements from the old name: 1. doesn't mention module swaps, which is an implementation detail 2. doesn't mention `Float8Linear`, which is an implementation detail 3. clarifies that this is for training, not to be confused with inference APIs 4. doesn't mention `linear`, which gives more freedom to add other modules later ``` find . -name '*.py' -print0 | xargs -0 sed -i 's/swap_linear_with_float8_linear/convert_to_float8_training/g' ``` Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 10a767f Pull Request resolved: #329
facebook-github-bot
added
the
CLA Signed
…aining`" Summary: Old name: `swap_linear_with_float8_linear` New name: `convert_to_float8_training` Choosing a more generic name, with the following improvements from the old name: 1. doesn't mention module swaps, which is an implementation detail 2. doesn't mention `Float8Linear`, which is an implementation detail 3. clarifies that this is for training, not to be confused with inference APIs 4. doesn't mention `linear`, which gives more freedom to add other modules later ``` find . -name '*.py' -print0 | xargs -0 sed -i 's/swap_linear_with_float8_linear/convert_to_float8_training/g' ``` Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jul 24, 2024
Summary: Old name: `swap_linear_with_float8_linear` New name: `convert_to_float8_training` Choosing a more generic name, with the following improvements from the old name: 1. doesn't mention module swaps, which is an implementation detail 2. doesn't mention `Float8Linear`, which is an implementation detail 3. clarifies that this is for training, not to be confused with inference APIs 4. doesn't mention `linear`, which gives more freedom to add other modules later ``` find . -name '*.py' -print0 | xargs -0 sed -i 's/swap_linear_with_float8_linear/convert_to_float8_training/g' ``` Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1ca4adf Pull Request resolved: #329
weifengpy
approved these changes
Jul 24, 2024
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request has been merged in da487a3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
convert_to_float8_training#329module_filter_fn#328emulateflag toFloat8LinearConfig#327Summary:
Old name:
swap_linear_with_float8_linearNew name:
convert_to_float8_trainingChoosing a more generic name, with the following improvements from the
old name:
Float8Linear, which is an implementation detailinference APIs
linear, which gives more freedom to add othermodules later
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60195665